Tim Hunt

Fix #317 handling of preserved comments in CSS

4

I hope this is OK. It is my first pull request here. Your CONTRIBUTING.md was very clear (thanks!) but I may still have missed something. If so, sorry, please let...

CSS minification logic for @license and @preserve is wrong, and sometimes very slow

6

This regexp is both wrong, and can be very, very slow on large input. ``` '/\n?\/\*(!|.*?@license|.*?@preserve).*?\*\/\n?/s' ``` https://github.com/matthiasmullie/minify/blob/master/src/CSS.php#L639 The error is that the .*? before the @licence will match anything,...

Selectors should recognise aria-label and aria-labelled-by where appropriate

3

The selectors defined in https://github.com/minkphp/Mink/blob/master/src/Selector/NamedSelector.php do a good job of recognising most HTML. E.g. they will find a checkbox by the associated , or a link but the alt text...

Cannot build on Windows

2

(Sorry, this is probably not a very useful or important bug report, but reporting it just in case.) The build fails on Windows (even though I'm not interested in running...

The redirect to the saml2-acs.php error page loses the URL you were trying to access

1

**What happened?** Because of how our test servers are set up (@sammarshallou could supply more info about that) whenever we switch from live server to test, or back we hit...

bug: dynamic type text sizes not supported

21

# Bug Report **Ionic version:** 4.11.0 **Current behavior:** On iOS, ionic apps ignore the preferred font size that the user has set in the system preferences. (Apple calls this Dynamic...

Behat failures don't fail the build

11

This is very odd, and more than a little annoying: https://github.com/moodleou/moodle-quiz_gradingstudents/runs/5512440974?check_suite_focus=true#step:17:134 ``` Running single behat site: Moodle 3.9.12+ (Build: 20220311), 7c52eaaf180ba34534c3b4106fe18ac7a02f0f20 Php: 7.2.34.28.20.04.1.1, mariadb: 10.7.3, OS: Linux 5.11.0-1028-azure x86_64 Server...

Reruns of Scenario outlines lead to potentially confusing scenario names

2

To explain what is going on, I am going to use a silly example, just to keep it short. Suppose random.html is a pointless page which displays 1 or 2...

Moodle coding style says that this is how it should be: ```php /** ... */ class base_class { /** * Document the purpose and contract of this method. */ funcition...

Deprecated: ucwords(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/moodle/question/type/coderunner/renderer.php on line 741

1

We are seeing this notice for some questions, running with PHP 8.1 ``` Deprecated: ucwords(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/html/moodle/question/type/coderunner/renderer.php on line...