Tim Hunt
Tim Hunt
Pull request #318 should fix this. (Don't know why github did no auto-link them.)
And for reference, the Moodle tracker issue for this is https://tracker.moodle.org/browse/MDL-68191.
Hi @davidscotson, this patch https://gist.github.com/timhunt/f969f46f60756197f320e03ed0d27a36 is what I was using in the Moodle context for debugging the performance. There is Hackery in theme/styles.php, so that it does not use the...
@davidscotson it would be easier to interpret the effect of the patch if you could run the two different versions of the code on the same server/laptop. Looking at the...
Thanks to scrutinizer for poniting out that this applies to JS too. Amended fix coming up.
Sorry, I don't understand whay appveyor is trying to do, and I can't work out what the logs mean. If I need to fix something, please explain. I felt it...
I was just wondering if we could get this fix landed? If you are waiting for me to do something, then please help me to understand what needs to be...
@davidscotson is a name a recognise. I was seeing crazy slow minification performace in our Moodle, so I put in some debugging to work out which regexp was being slow,...
OK, got it! The problem was that the .* before the @licence could match anything, including */. Therefore, it was (slowly) consuming vast chunks of the input. The following runs...
I just made a separate issue #317 for what I found.