Tim Holy
Transferring to FlameGraphs. That's where the real work would need to be done. (It's a little unfortunate it wasn't added there for vscode's version; Flame
I'm also unsure what this is about. But looking at the code, I noticed two Pkg-related and one julia-options candidates: - https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/utils.jl#L38 - https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/persistent_tasks.jl#L81 - https://github.com/JuliaTesting/Aqua.jl/blob/1fca5d9fc494a1c80618d7352655373be7c8d82c/src/persistent_tasks.jl#L112 Since I don't know...
Strange, with this code: ```julia mat = zeros(Float64, 3, 3) list = [1, 2, 3] mat[:, :length(list)] ``` I get ```julia julia> includet("parseerr.jl") ERROR: MethodError: objects of type Symbol are...
Aha, it looks like CI caught a case where the new flatness test (without the flatness check) spent 32 iterations in a flat basin. That's a little closer to the...
Oh interesting, it's also the `StrongWolfe` algorithm. With this diff: ```diff diff --git a/test/issues.jl b/test/issues.jl index 7b40677..b37a851 100644 --- a/test/issues.jl +++ b/test/issues.jl @@ -57,14 +57,15 @@ end BackTracking(; cache=cache), BackTracking(;...
In trying this locally, I got this many passes (out of 1000 attempts): - HZ: 963 - StrongWolfe: 988 - MoreThuente: 1000 - Backtracking (both): 999
OK, this was more successful in capturing the purpose of the flatness check than I initially thought. Maybe best to wait to merge this for an actual fix.
Seems like there must be a `[compat]` bump that should have happened but didn't. This should be a package incompatibility error, not a build error. EDIT: xref #4120
From slack, for when I have time to get back to this: > Text has offset which is in screen space (like the text itself) so it lends itself to...
Update on why this isn't moving forward: I've now seen other cases where overlap with non-text objects is also an issue. I'm uncertain that a text-only solution will be satisfying,...