Tim Hoffmann

Results 739 comments of Tim Hoffmann

Current CI doc builds are down to 11-12min due to some other optimizations, which is okish and faster than some unit test runs. One thing to note is that we...

> It would be great if the plot and scatter functions would allow the marker kwarg to be a list. `plot` is requiring identical markers (semantically as well as from...

When working on this, I'd like to see a discussion of my concerns at https://github.com/matplotlib/matplotlib/issues/18040#issuecomment-663219630.

I'm a bit unsure whether and if how far we should go here. ### spinex What are "reasonable" values other than 1? Possibly 1.2 for [two axis on the right](https://matplotlib.org/stable/gallery/spines/multiple_yaxis_with_spines.html)....

I we could do something like this ```python def twinx(..., location="right", spine_position=None, ...): ... _api.check_in_list(["left", "right"], location=location) if location == "right": # current hard-coded tickright, label and offset position setting...

AFAICS, what you have implemented is a subset of the [fill_between](https://matplotlib.org/devdocs/api/_as_gen/mpl_toolkits.mplot3d.axes3d.Axes3D.fill_between.html) API. For example, you could do ``` x = [-1, -1, 1, 1] y = [-1, 1, 1, -1]...

@kyracho gentle ping. Do you plan to continue with this?

@Kaustbh you've requested a review, but have not reacted to my previous comments. They still stand.

You shouldn't necessarily document the formulas (as equation), but describe the logic; and for the logic, yes we need all cases - though you may group them together as e.g....

It would be simpler to review to put this into a commit, then I could annotate / suggest on individual parts. > If scale_units is None [...] It's not immedately...