Tim Hoffmann

Results 739 comments of Tim Hoffmann

> Interesting @timhoffm - I had never noticed this as I am an Android user and have never had anyone flag this before. Is this standard behavior regardless of the...

> As I've already mentioned in the PR (https://github.com/sphinx-doc/sphinx/pull/12618#issuecomment-2287114255), I don't think this should be part of the basic theme. I think derived themes should have all the freedom to...

I'm somewhat concerned on this approach. - The rewriting of docstrings is higher magic. Single backticks have a clear meaning in Sphinx (prefix it with `default_role`). Overloading that semantics in...

One related aspect to think about: Do we anticipate that we'll need a distinction between x and y axis as well? Because if so, we should directly introduce these.

> between x and y axis"? Do you mean something like > > ```python > rcParams["grid.major.xaxis.linestyle"] = ":" > rcParams["grid.major.yaxis.linestyle"] = "-" > ``` Basically yes. Exact spelling t.b.d.

We already rely on `Tick.__name__` see https://github.com/matplotlib/matplotlib/blob/3b329d92868d7cf84e577123aefbf3211ea83d52/lib/matplotlib/axis.py#L106-L116 It's ok to use that. Spelling: We have "xaxis", "xticks", "xscale" as axis-dependent names (but they are all also used in the python...

No, we don't need "grid.xaxis.linestyle". If starting from scratch, I'd just have the granular settings "grid.xaxis.major.linestyle" etc. After all, these are advanced style configuration options, and if somebody cares to...

> Also, I tried to resolve the stubtest unsuccessfully. I suppose you've tricked yourself. You've made the `_validate_linestyle` parameter names consistent, which renders the allowlist entry unnecessary (and mypy complains...

Please put it in `test_axis.py`. This is where the semantic code lives and where it logically belongs. `test_rcparams.py` is only for the rcparams infrastructure not testind individual values.

Then use `ax.xaxis.get_major_ticks()[0].gridline`. There are various ways to drill down, and not all are complete or consistent. Sorting/consolidating that is for another time. Let's not create more functions as part...