Tim Hoffmann

Results 739 comments of Tim Hoffmann

Naming: Not sure `ScalarMappableShim → ColorizerShim` is meaningful. I would say, this a *Shim for the ScalarMappable API* and hence, `ScalarMappable` in the name makes sense. Note 2: Yes, please...

> > The shim provides the backward-compatible interface for the ScalarMappaple API. It‘s needed for the foreseeable future, but it’s reasonable to keep it separated from the ColorizingArtist API. >...

> but one or both should confirm I'm on mobile-only for the next week. Please do not expect a detailed review from my side in that time. Last time I...

> but I didn't find a way to do that without also listing the member functions of Artist. I believe this is a limitation of the sphinx autodoc. We have...

Artist instantiation + add_artist should not be a first-class user-facing API. The standard pattern in matplotlib are functions to create the artists. I'd be very reluctant to dilute this. Frist...

Milestoning 3.2 as there has not been activity recently. @mromanie are you still interested to work on this?

> It looks like there isn't much left to do here Um, I disagree https://github.com/matplotlib/matplotlib/pull/13374#discussion_r1991960929

> o me put labels next to rather than on top reads like a relatively small/clear change if there's agreement that that should be the position. > > What am...

> Is there any chance that this will be implemented soon? This is not a priority of the core developers. So unless somebody steps up to contribute, it won’t be...

To be clear, the purpose of `:mpltype:` is to create links for type-like concepts that do not have a direct class representation. Linestyle does fall into this category. The usage...