Tim Dorr

Results 176 comments of Tim Dorr

@felipeloge An easy workaround is to add `Request.prototype.signal = {}` somewhere globally in your app as a "polyfill" of sorts.

Can anyone provide some sort of reproduction of this issue? Either a GitHub repo or StackBlitz/CodeSandbox will work.

This looks to be related to #14457. If I downgrade to 7.9.4, it works just fine. The context instance is different for the DOM export from `react-router`.

Does this only occur in the root layout? I would recommend not putting too much logic in there and instead relying on a separate layout route, even if it's applied...

What does your vite.config.ts or react-router.config.ts (if you have one) look like? Based on what you've said, you've got a custom Express server instead of using the @react-router/dev server. Does...

Could you remove the upgrades to Vite in the package.json files? You only need to upgrade with pnpm, because that version selector will include 6.3.0.

No, I was just trying to cut down on noise in the PR so the change is more visible.

This is definitely related to require(esm) being unflagged: https://nodejs.org/en/blog/release/v20.19.0#requireesm-is-now-enabled-by-default I'm not 100% sure, but this may be a Vite bug? I can get `vite preview` working when setting `NODE_OPTIONS=--no-experimental-require-module`. But...