Tim Dorr

icon indicating a website link https://tim.do/rr

icon location Atlanta, GA icon location Former Managing Director of @Techstars Atlanta. Cofounder of @onspaceship and @SalesLoft. Self-made intern at @reduxjs and @remix-run.

Results 176 comments of Tim Dorr

chore: fix some comments

You need to add your username to the contributors.yml file. That is how we track signatures.

chore: fix some comments

Tanks!

Bug: path aliases don't get correctly resovlved in `routes.ts`

@GabenGar That kind of discussion isn't really productive to the conversation here. This is simply a matter of routes being allowed to use TS to resolve modules, which may be...

[Bug]: Issues with content update after react-router v6.25.1 change – requires multiple interactions or keydown event to reflect changes

Can you provide a reproduction of this issue on something like Codesandbox or StackBlitz?

Generic for useLocation to allow to provide type for Location State

This has been suggested many times. This would actually remove type safety, as you would be overriding `state` to that type. You should be using type narrowing to determine the...

Format all files

Can you leave the `.yarn/releases` folder out of these PRs? Those should remain untouched as an artifact stored in the project.

Format all files

Alrighty, let's merge this in. Thanks!

fix(react-router): handle parameters with static suffixes in generatePath

This PR is against the `dev` branch, which is the 7.x version of the code. I think you meant to base this against `v6`, which is for the 6.x version.

Build errors after adding UI library in a project started from a Cloudflare template

I believe this is related to remix-run/remix#10455

SPA Mode + `<NavLink to="/" end>` rendered in `root.tsx` Layout component will always start as "active"

As you commented, this is essentially a "misuse" of NavLink within the root module. And you are also correct that we have poor documentation here. We have #13000 open to...