Tim Abbott

@ahmedabuamra have you had a chance to resolve the feedback on this?

@adarshpk thanks for the pull request! I guess https://github.com/zulip/docker-zulip/pull/166/files is actually the same; we should definitely merge one of these. Do you know what the conventions are in the Docker...

This fixes the regex issue 78480d4de548c6fccfc51d5434d2ad143db5f736 (and also makes the code a lot cleaner).

Single quotes are obviously the better choice than double-quotes in YAML; just merged b2bb979b4ef632b2369045c4358b03af5c107671 to migrate the project.

For > The variables used for passphrases should fail if not supplied; i.e. > `SECRETS_secret_key: "${SECRETS_secret_key:?err}"` It seems to me that we should be making a set variable that's empty...

@jeaye for this one: > Passphrases should be escaped when they're sent to Postgres and other services is the block that needs escaping this, or something else? ``` export PGPASSWORD="$SECRETS_postgres_password"...

> "${SECRETS_secret_key:?err}" is fatal (as per the ?err), as described here. Understood, I'm just noticing we seem to have code checking for blank secrets and just printing a line of...

On the database front, it looks like it fails here: ``` database_1 | 2018-08-23 20:20:50.925 UTC [66] ERROR: unrecognized role option "fun" at character 52 database_1 | 2018-08-23 20:20:50.925 UTC...

Agreed re: reporting upstream; can you take reporting this one? And yeah, if we're providing a tool, we can just have the tool not use `$` and `'`.

Awesome! I guess we need to wait for them to do a release before we can take advantage of this?