docker-zulip icon indicating copy to clipboard operation
docker-zulip copied to clipboard

Use docker managed volumes in docker-compose

Open adarshpk opened this issue 4 years ago • 4 comments

This is so that the compose file works across different platforms with no issues (I had an issue regarding permission to /opt directory).

adarshpk avatar Jun 11 '21 07:06 adarshpk

@adarshpk thanks for the pull request! I guess https://github.com/zulip/docker-zulip/pull/166/files is actually the same; we should definitely merge one of these.

Do you know what the conventions are in the Docker community on naming volumes?

timabbott avatar Jun 29 '21 19:06 timabbott

@timabbott I'm unaware of the volume naming conventions if any.

adarshpk avatar Jul 04 '21 16:07 adarshpk

I have used many docker-compose based projects over the past several years. There are no hard conventions. The proposed names in the PR are sensible.

I would support merging this PR to improve zulip's alignment with docker best practices.

Note that docker-compose will "namespace" the volumes by prepending the project name (which defaults to the directory containing the docker-compose.yml file). This means the actual docker volumes will typically be named zulip_postgresq, zulip_rabbitmq, etc.

jasonhildebrand avatar Sep 08 '22 14:09 jasonhildebrand

#166 is now closed by the author. @timabbott, please consider merging this PR. You raised backward compatibility concerns in https://github.com/zulip/docker-zulip/pull/166#issuecomment-437986089, but I think that https://github.com/zulip/docker-zulip/pull/166#issuecomment-615525202 answers them pretty well.

i-ky avatar Sep 30 '22 08:09 i-ky