Tim Abbott

Results 1372 comments of Tim Abbott

OK. I think the `users.noreply` thing is a really good tell for Gitter; let me verify that. Hmm, no, it's not great. It's possible we should just do Gitter by...

I merged the first commit as 8bcdbc720e3a7203fc0056bb8c81d5847b39464b, just to head off merge conflicts.

OK, I'm feeling pretty good about this PR. A few ideas: * Can we drop the `lock_usermessage` stuff for now, and leave that for a follow-up PR? I feel like...

Yes, agreed, I think that's fine to leave as a follow-up project for now but let's not lose track of it. (Probably we'll want to open a few issues when...

@abhijeetbodas2001 let me know when this is ready for a next review.

I merged most of this as the series ending with 86d6872a80f626993e3c33fcbcac3236c9fbb8de, after editing comments/docstrings lightly. Huge thanks for doing this migration @abhijeetbodas2001! @mateuszmandera @alexmv FYI :). In production, we're likely...

We may want to avoid locking the `Message` row while calling `render_incoming_message`, just because that's a potentially slow operation and every situation where we hold a lock for a long...

Yeah, `durable=True` works for places where we intend that -- I think we might have a place where we want `savepoint=False` because the function can be called from multiple code...

Just an update that the parts of this that are already merged are now now running happily in production.

Thanks for working on this @WesleyAC! @alya FYI to look at the screenshot. Also the node tests fail, I haven't investigated, but probably we have a test that look at...