zulip icon indicating copy to clipboard operation
zulip copied to clipboard

Quote and reply or forward label

Open WesleyAC opened this issue 4 years ago • 4 comments

See CZO thread

Testing plan: Manually tested

GIFs or screenshots:

screenshot

WesleyAC avatar Jun 09 '21 00:06 WesleyAC

Thanks for working on this @WesleyAC!

@alya FYI to look at the screenshot. Also the node tests fail, I haven't investigated, but probably we have a test that look at one of these strings.

timabbott avatar Jun 09 '21 00:06 timabbott

Fixed up the test :)

WesleyAC avatar Jun 09 '21 00:06 WesleyAC

./tools/test-js-with-puppeteer user-deactivation.ts works fine for me locally, so I presume the failure is a flake?

WesleyAC avatar Jun 09 '21 02:06 WesleyAC

Heads up @WesleyAC, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

zulipbot avatar Sep 07 '21 16:09 zulipbot