Tim Abbott

Results 1421 comments of Tim Abbott

@akshatdalton can you post a screencast showing this working?

I merged the first few commits as the series ending with 3015837e6e3206c4381cbcacfe2be391d03dc9cb; the last couple add new strings and have some other minor issues, so it's not worth trying to...

I merged the commits through bad3fe40e560290b53fcea44c075cf5aeb093bd8. Agreed, all templates for settings UI should be in `static/templates/settings`; we probably missed that one due to its inconsistent name.

See 41a477bbfb96922927f6eba45cc249b360025958; you should always fix linter errors in the commit that introduced the bug, or we'll get test failures when merging things incrementally.

I merged the template files renames as the series ending with b98ad46459654ddf48a4d2403454788bfc65ba3b, and also cherry-picked 0f3d45f0786b8a047b650773249b3d9f37a431ed. Thanks @akshatdalton! I'm not sure about the string changes you have in the tooltip...

(I'd be happy with the next commit for this being a `tippyjs` migration with no string changes, so I don't think the specific commit split you suggested makes sense to...

We don't seem to have had reports of bugs on chat.zulip.org obviously traced to this, so we could consider merging (parts of) it.

I merged the first change after some documentation changes as 684908bdce44610c93ce9ef63d5a56f98bc233e1. For the second commit, I think we want to actually be migrating to functions like `do_set_realm_property` when updating state;...

@sravitha welcome! This change needs tests and screenshots from the `/emails` tool in the development environment to be considered. Check out the Zulip commit message guidelines as well: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

Thanks for rebasing this; I'm in the middle of replacing this with a complex refactoring branch that makes the code path a lot more readable, since I found it really...