Till Krüss

Results 293 comments of Till Krüss

packal.org is dead I think.

I'd like the answer to that question as well.

@rverrips: I'm open to PRs, just keep 'em separate 🙂

This works for me on macOS using iTerm2: ``` gh repo clone laravel/framework gh pr checkout 41718 vendor/bin/phpunit ``` But I do get a couple of incomplete tests: There were...

>Currently the Cache component does not support any of the serializer/compressors. I want this test suite improvement to be merged first before I submit the next pull request that adds...

Tests run fine for me on macOS 12.4 using iTerm2 3.4.16.

Yeah, it's hard to make this PR smaller. Maybe someone who gets the wonky output can do a quick call for diagnostics?

@danielbachhuber: It seems that `wp_cache_init()` is called after `Logger::start()` and thus this line will always be `false`: https://github.com/wp-cli/profile-command/blob/ef7bcac43e9e6b619aa3edaf6f842fb2a65d80fc/inc/class-logger.php#L76

@danielbachhuber: Sorry, I think that was off topic. How do you feel about a singular `cache_calls` vs `cache_reads` & `cache_writes` as a standard?