profile-command icon indicating copy to clipboard operation
profile-command copied to clipboard

Integrate with persistent object caches

Open danielbachhuber opened this issue 9 years ago • 5 comments

For the persistent object caches that track additional debug information (e.g. redis_calls), it would be helpful to expose it.

To start with:

  • [ ] WP Redis
  • [ ] WP LCache

danielbachhuber avatar Aug 26 '16 22:08 danielbachhuber

@danielbachhuber: It seems that wp_cache_init() is called after Logger::start() and thus this line will always be false:

https://github.com/wp-cli/profile-command/blob/ef7bcac43e9e6b619aa3edaf6f842fb2a65d80fc/inc/class-logger.php#L76

tillkruss avatar Sep 25 '20 18:09 tillkruss

Hi @danielbachhuber :)

Just a +1 to mention Pagely's customers would love to see better integration with profile and persistent object caches. As more sites start make use of both features it would be great if they worked together a little better. Keep up the excellent work!

azakaryan-godaddy avatar Sep 25 '20 18:09 azakaryan-godaddy

@schlessera ping 🙂

tillkruss avatar Sep 25 '20 20:09 tillkruss

@danielbachhuber: Sorry, I think that was off topic. How do you feel about a singular cache_calls vs cache_reads & cache_writes as a standard?

tillkruss avatar Sep 28 '20 21:09 tillkruss

@tillkruss I'm no longer maintaining this command, sorry.

danielbachhuber avatar Sep 28 '20 21:09 danielbachhuber