Till Hoffmann

Results 159 comments of Till Hoffmann

@arpost, do you know whether this issue is related to the fix you added in #100?

Testing on gitlab CI is rather difficult because of [this issue](https://gitlab.com/gitlab-org/gitlab/-/issues/5667). In short, gitlab cannot run CI on forks which means every change would first have to be pushed onto...

Interesting, @jakobbraun. Do you know why this resolves the issue? It seems to me like the fixed version should give the same result. In particular, the call sequence is as...

Would you mind trying this snippet just to check that we have a valid `host` variable? ```python class FixedPostgresContainer(PostgresContainer): """ This class fixes a bug that the PostgresContainer does not...

Thanks for the fix. Would you mind adding a test demonstrating what behavior this change fixes (the existing tests seem to pass fine without the change in `db_name`)?

As far as I'm aware, there is no reason why we can't use ryuk. Contributions welcome!

Thanks for the updated PR! It looks like it is reverting a number of changes introduced in previous work, e.g the docker version from #203 or clickhouse support from #173....

Thanks for reporting, @NikZak. Are you up for putting together a PR?

Thanks for the additions and apologies for the slow reply. A few things to get this integrated: - Rebase on master. - Regenerate requirement files. - Add `cassandra` and `scylla`...

We may have to get #209 merged first to get around the google dependency issue.