testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Supporting Ryuk container

Open fsonntag opened this issue 5 years ago • 2 comments

So I'm using testcontainers within Java, as well as Python. I noticed that sometimes containers stick around in Python, while in Java they always get cleaned up properly thanks to Ryuk.

I was wondering, if that was a decision made on purpose to not use Ryuk in the Python project? Otherwise supporting it would be really great, in order to keep the docker environments of the host machine clean.

fsonntag avatar Jul 01 '20 08:07 fsonntag

As far as I'm aware, there is no reason why we can't use ryuk. Contributions welcome!

tillahoffmann avatar Jul 03 '20 10:07 tillahoffmann

Thanks for the feedback, I will look into it when I can find some time. But ofc also wanted to make sure beforehand if there was a specific reason :)

fsonntag avatar Jul 03 '20 10:07 fsonntag

Closing this for now as #208 addresses a similar issue.

tillahoffmann avatar Jan 06 '23 20:01 tillahoffmann