testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

Make the GCP PubSub container work

Open hy9be opened this issue 3 years ago • 2 comments

Accidentally closed the PR under review https://github.com/testcontainers/testcontainers-python/pull/183 and cannot reopen it. Recreated this one.

Changes

  • Replace with_exposed_ports with with_bind_ports
  • Modify the context manager to set and unset environment variable as mentioned in https://cloud.google.com/pubsub/docs/emulator#env
  • Update the test
  • Update the pubsub gcp lib versions

hy9be avatar Apr 24 '22 16:04 hy9be

Thanks for the updated PR! It looks like it is reverting a number of changes introduced in previous work, e.g the docker version from #203 or clickhouse support from #173. This may be the result of copying code from an outdated branch. That's also the reason for early test failures.

tillahoffmann avatar Apr 27 '22 15:04 tillahoffmann

Yeah, I think you are right. I will take a look.

hy9be avatar Apr 27 '22 15:04 hy9be