James Bromwell

Results 257 comments of James Bromwell

Yeah, you're right, Directive makes more sense than Component because as a base class it's all functionality and no style or content / template. But really it's not even a...

What does `enableIvy: false` do now? I thought Ivy was the only template engine available in v10+.

Can't you just use a `protected abstract writeValueCallback: (val: T) => void` as a member, instead of passing it as a constructor argument? If the problem is that you need...

As a JSDoc yellow-belt, I don't really understand. Is there a difference in meaning between `.` vs `~`, such that one is "correct" here and the other isn't? Or are...

Sounds like "namepath" is the magic word I was missing. Thanks! Does this mean that Matt's original documentation was technically using it wrong? I think he was documenting the public...

That seems like an oversight in the JSDoc docs. On the `@callback` page they use `~` as the namepath connector, but on the "About Namepaths" page they do not mention...

I don't see any open issues on jsdom's tracker, but IMHO the best fix here would be for them to build and export their own TS typings, instead of including...

I assumed that they don't use TS, but plenty of vanilla JS libraries take ownership of their TS types, to support their TS-using community. What I meant was, it would...

I just opened #45869. I think maybe the best-case outcome would be implementing #13219 (throws-clause) and this issue, in which case it would become possible to document Promises that have...

If you read the issues I linked from my previous post (2 years ago!), you'll see some of the reasoning. I think one of the most compelling arguments *against* allowing...