Oliver Erhart comments

Results 67 comments of


                                            Oliver Erhart

Target property mapped more than once inspection

Nice @hduelme! > If a own annotation containing @Mapping or @Mappings is used the error is reported on the annotation directly For this scenario there might be a "remove `@MyMappingAnnotation`"...

MapStruct does not detect unmapped source attribute if it nested.

Hi @foal! Yes, nested objects are tricky for MapStruct. There are some known issues when flattening nested objects to an upper level like: * #3217 There is the following issue...

#3617 support for target this enum mapping.

Thanks for your work on this @Zegveld! I checked it out and played with it a bit, and yes, this solves the problem when an enum is used as a...

Improve documentation of `nullValuePropertyMappingStrategy`

Hi @cpolisini-commify! Thanks for reaching out and glad that you found the solution. What parts of the documentation do you suggest to be improved, and how? Thanks in advance.

make mapping target object to null when all its properties are null

Hi @evipin, could you please provide code of some models and the mapper and what you would like to be generated?

Support referencing a method instead of an expression for a Mapping

Just adding my two cents, we're also using something like `now()` quite often, so something like this would come quite handy.

Support referencing a method instead of an expression for a Mapping

@filiphr Yeah, I also think the first option fits the best. Providing a `@Context` should also be supported, I think?