Oliver Erhart

Results 67 comments of Oliver Erhart

> Okay, everything should be done now. I hope I haven't missed anything. > > I still have a question: All workflow jobs fail with: "Some files do not have...

Yeah i tested this on main. Thanks for the hint, I totally forgot about the new feature. Test is green, however it is is then not picked up when the...

@filiphr Feel free to rename it as you like, I found no better way to describe it. 👍 Thanks in advance!

@filiphr Thanks for your work on this! The test in the pull request is green, however the generated code does not look correct. I think there are still several problems...

Thanks for revisiting this. I hope I have not added any more confusion by providing the permuted tests. > What is wrong with the generated code for the test in...

> Your last comment is contradicting the one before 😉. Yep, true. 😅 Okay, now I got it, this cleared it up for me: > // We are mapping a...

> I had a look at it, and I'm not sure that I like the new things in `mergeInheritedOptions`. It feels like we are doing multiple things in the same...

> If you want I can look into refactoring those bits? Yes, you're welcome to do that. I'm curious to see what it looks like after the refactoring. 👍

Records have been supported since 1.4.0, see #2014. However, they never made it into the reference guide. It seems that the interface interferes with records. Thanks for the detailed report,...

> @thunderhook, could you please take a look at the PR? I'm sorry, I'm on holiday at the moment. Maybe I can make it in about 2 weeks if Filip...