Oliver Erhart comments

Results 69 comments of


                                            Oliver Erhart

@AfterMapping methods are called twice when target uses Lombok @Builder annotation

Hi @rainer-wei! Thanks, that slipped through. This is also the case for `@BeforeMapping`. I provided a fix in #3680.

check target property is non null before copy value

This can be done with the help of conditions: ```java @Mapper interface UpdateConditionMapper { @Mapping(target = "someName", source = "name") void update(Source source, @MappingTarget Target target); @Condition // when you...

check target property is non null before copy value

Of course, sorry for the confusion. I have no idea how I got the source and target conditions mixed up. We don't support `@TargetProperty` yet? I can't find the issue...

Specify prefix for data from nested object when flattening the data

Just for reference, this has also been asked in: * #798

#3678 Prevent duplicate @BeforeMapping and @AfterMapping calls on classes that use the Builder pattern.

> I'm not sure the fix is correct. > > How will this behave for something like: > > ```java > @Mapper > public interface CustomMapper { > > Target...

#3678 Prevent duplicate @BeforeMapping and @AfterMapping calls on classes that use the Builder pattern.

So, i tried to adapt the method retrieval process. It became confusing very quickly and hard to differ between callback lifecycle methods that belong to the builder object and the...

#3678 Prevent duplicate @BeforeMapping and @AfterMapping calls on classes that use the Builder pattern.

> Thanks @thunderhook. I'll need some time to think about this. I'm not too fond of the removals. I would prefer if we can select the right types when we...

#3678 Prevent duplicate @BeforeMapping and @AfterMapping calls on classes that use the Builder pattern.

@filiphr Short heads up: Unfortunately, I won't be able to do this any time soon. What do you think about merging the fix with this variant and creating a refactoring...

NullValuePropertyMappingStrategy.SET_TO_DEFAULT with List property

This may be related or even a duplicate of #2843

Improving decorator with spring constructor injection.

I also think it can be improved. I would like to have a look at it, but I need a reproducer. I haven't been able to create one. With `1.6.0.RC1`,...