Thiago Silva
Thiago Silva
Migrates or marks to remove tests that use UDP. - Migrated when it is possible to do so. - Otherwise marked to be analyzed or removed Fixes issue: https://github.com/nanocurrency/nano-node/issues/3846
Most of the related source-code to UDP network protocol is now dead code. UDP should be removed. - [x] Rewrite unit tests from UDP to TCP or loopback channels. -...
- Brings part of the updates made by Russel (https://github.com/argakiig/raiblocks/tree/rpm_building) in the `changelog.py` script, but removed the tag option, as it can be passed to the end option (-e). -...
There is a [recommendation in the docs](https://docs.nano.org/commands/command-line-interface/#-confirmation_height_clear) for not using this option when the node is already running. This may lead to misbehavior on the node. Got a suggestion from...
For safety, the confirmation_height_clear should be changed to require an account argument. This argument should have either an account number or `"all"`, to specify the confirmation height of all accounts...
Header wrappers such as `#include
Got an UBSan error report from Address Sanitizer when running it upon core_test. ``` /ws/nano-node/nano/node/xorshift.hpp:18:12: runtime error: left shift of 3860899979500397099 by 31 places cannot be represented in type 'uint64_t'...
Got an UBSan error report from Address Sanitizer when running it upon core_test. ``` /ws/nano-node/nano/lib/numbers.hpp:278:46: runtime error: unsigned integer overflow: 18363490017020192492 + 15047902047331995846 cannot be represented in type 'unsigned long'...
Running ASan (Google Address Sanitizer) on core_test build got the following report: ``` /ws/nano-node/nano/node/ledger_walker.cpp:76:59: runtime error: reference binding to misaligned address 0x7fbb71c92064 for type 'const nano::block_hash', which requires 8 byte...
Disabled in [#3622](https://github.com/nanocurrency/nano-node/pull/3622) CI run in which it failed: [here](https://github.com/nanocurrency/nano-node/runs/4569227726?check_suite_focus=true) ``` 2021-12-18T12:05:29.2196655Z [ RUN ] network.peer_max_tcp_attempts 2021-12-18T12:05:30.7059330Z Could not open lmdb environment: -1073741523, 2021-12-18T12:05:30.7101613Z Assertion (status4 == 0) failed 2021-12-18T12:05:30.7104563Z...