Thiago Silva

Results 12 comments of Thiago Silva

Added a PR for this in nano-docs repo: https://github.com/nanocurrency/nano-docs/pull/507

Closing this as it was broken into multiple smaller PRs

@dsiganos , @clemahieu , how the reverse links table could get affected by the confirmation height?

Update also upon the changes from this PR: https://github.com/nanocurrency/nano-node/pull/3851

Thanks for the suggestion. My opinion is I'd rather name it as "third_party" as they are not submodules, but third-party code.

1. The node itself is composed by multiple parts we have not been able yet to have them in a fully containerized implementation (in a loose coupling way) that we...

Marked as draft until fixing two remaining tests: - peer_container.split - peer_container.depeer

Will resume this after https://github.com/nanocurrency/nano-node/pull/3928 is merged.

Better to have a GitHub issue to properly track these, could you fill them @fikumikudev ?: - TODO in future PR: Provide a dedicated Dockerfile for building and running tests...

Will mark this as ready for review when the runner setup is finished.