Thomas Van Lenten

Results 70 comments of Thomas Van Lenten

This is because each `swift_proto_library` ends up being a module. If it was anything other than `public` how would it be used?

Slightly aside, but how are defaults handled for rules vs. macros? The example above uses the docstring on the macro to record the default value, but since defaults are also...

So that works for when the macro has a default, but going back to your example: ```python def my_rule(name, **kwargs): """@inherit(_my_rule) Args: foo: @argdoc(_my_rule.foo). `name` + ' something' by default....

Looks like the problem is `input` is a `attr.label()`, so it won't accept something that expands to >1 file even though the `StarlarkLibraryInfo` provider has the distinction between `srcs` and...

I'm not sure I follow how #69 helps? Since the `stardoc` rule takes a label that has to expand to a single file, it can't ever reference a `bzl_library` instance...

Ah, I guess it will depend on if there is still a `stardoc` rule to do the generation? If says a `genquery` is used as _input_ to that rule, then...

Sent you an email directly. I'm not sure if you can see the result of this on github without pushing the generated md files to something like a github wiki....

ps - doing a `make` within `conformance` also cause other things to get left behind.

That's fair. I was looking at a case where I have to use a wrapper for other Starlark reasons, and I'd really like to to appear as a `rule`. Maybe...

All the test pass locally, and the failing tests don't seem related since I didn't change any files used in those tests.