Thomas Van Lenten

Results 68 comments of Thomas Van Lenten

@sergiocampama isn't this going to be the test runner and not the `ios_ui_test` rule itself?

The runner is an external dep: https://github.com/bazelbuild/rules_apple#quick-setup, _ xctestrunner_ That's what is defaulted into the `runner` argument on `xc_unit_test`.

If we silently drop the files, it does mean bazel will rerun the action when just the `.DS_Store` file changes. And since lots of Apple tools produce files with timestamps,...

#177 should clear things for the repo.

@c-parsons I thought there was a discussion recently about how some of the rules added to skylib already were likely a mistake, and to say on charter the though was...

Drive by (as the part of the original authors) – What makes you say `PathToUnderscores` is "more portable"? A big problem with `PathToUnderscores` is collisions: - `foo/bar/user.proto` → `foo_bar_user.pb.swift` -...

Just for reference, I believe the cc compiling apis (and `cc_library` and `objc_library`), deal with the collisions by ensuring the .o files all get unique names. I'm not sure if...

Also, exactly what flags do you have enabled on the build? Isn't the a feature for a side module cache, do you have that enabled and thus you might have...

[Looks like](https://github.com/bazelbuild/bazel-skylib/blob/master/skylark_library.bzl#L51-L56) `deps` can be source files directly or `skylark_library` labels. So to handling indirect you'd also have to double check the deps for direct files and check those. You'd...

fyi - ObjC (and Swift) both have apis for delimited messages.