Thomas Van Lenten
Thomas Van Lenten
Given the size of the offset (`GPBCodedInputStreamCheckLastTagWas + 45880` and the varying sizes of the others), what's likely crashing probably isn't in ObjC Protos and it likely some library with...
Is there a longer version of the error message? Does it say where it things both definitions come from? @paulb777 any ideas? Is the old file imports the new, I...
The screenshot doesn't actually provide the details that are in the Xcode log. All the screen shot has is "Previous definition is here", and you'd have to click on it...
> @thomasvl How could I share the full build log? Sometimes I would love to actually see it. Expand open the log and you can copy the text. Here's an...
Taking a quick look at this, I don't see an issue: ```diff diff --git a/objectivec/Tests/GPBMessageTests.m b/objectivec/Tests/GPBMessageTests.m index b2c75ba0c..bc828553a 100644 --- a/objectivec/Tests/GPBMessageTests.m +++ b/objectivec/Tests/GPBMessageTests.m @@ -93,6 +93,16 @@ @implementation MessageTests +...
Extending the diff into the `.swift` test files also seems to show things working: ```diff diff --git a/objectivec/Tests/GPBSwiftTests.swift b/objectivec/Tests/GPBSwiftTests.swift index 03d751068..0117d82db 100644 --- a/objectivec/Tests/GPBSwiftTests.swift +++ b/objectivec/Tests/GPBSwiftTests.swift @@ -35,6 +35,15 @@...
Expanded the test to nest a message also, and I'm still not seeing any issues. This works in the iOS and macOS Xcode projects in the objectivec directory: ```diff diff...
Ugh, yea, there's not anything the library can do for that, if you are using other libraries that are clamming selectors on NSObject it's going to have issues like this....
@allevato likely knows the most about this.
Before these rules can support it, bazel would need to support for the needed architecture/platform triplet to the compilers, i.e. a new toolchain from their pov. So if you are...