Thomas Honeyman

Results 255 comments of Thomas Honeyman

> Why don't you just pattern match the newtype? Good point. Though that wouldn't help in the case of `map unwrap`, where we can coerce the container itself, right?

After looking further through the plans for safe coercion and #3890 I would rather not introduce the `unsafeCoerce` calls. Instead, I suggest we pattern-match on the newtype instead of calling...

`purescript-dom` is deprecated, and so you'd be looking for https://github.com/purescript-web/purescript-web-dom instead. I don't think there's a reason `onCompositionStart` and `onCompositionEnd` events have been omitted from Halogen, and I'd be happy...

Could you mock all network calls so they fail the test right away if called? You could use these mocked calls for the offline mode test only.

I'd welcome a PR to update the docs to link to the Halogen template with a brief note about using the template instead of Try PureScript to run the examples....

This would conflict with the `data` keyword, but we could add a `data_` helper function. I'm not sure what stance @garyb has on non-standard attributes.

It’s probably there just because that’s a standard pattern for component files, but since this is the root component you’re right there’s no real point. I’d be happy with a...

On second thought, if `--quiet` is needed for workflows where you really don't want _any_ Spago output leaking through, then I understand why logging would just be disabled in general...

Reading through the Mozilla documentation it looks like this property is considered legacy and they suggest `allow="fullscreen"` as the preferred attribute now. It seems that supporting the `allow` attribute with...

I took a moment to walk through the documentation on MDN. I’d like to share some snippets from the documentation that describe the purpose and syntax of this policy —...