Thomas Eizinger
Thomas Eizinger
@mdvmeijer went through the work of packaging this up for nix in https://github.com/mdvmeijer/fw-fanctrl-nix. I am wondering if you'd be open to having any of these changes upstreamed? Note that a...
According to the multiaddr spec, `/wss` is deprecated, see https://github.com/multiformats/multiaddr/blob/master/protocols.csv#L33. We should reflect this in the code such that downstream users can upgrade accordingly. I'd suggest we mark it as...
As discussed in https://github.com/multiformats/rust-multiaddr/issues/71, we should remove the `from_url` module to reduce the surface area of this crate's public API. Users are encouraged to implement the `from_url` functionality themselves and/or...
As an effort towards #71, I propose to make `Error` an opaque struct. This allows us to rename variants, as well as add or remove some of them or change...
It would be good if we can offer an easy way for people to integration test that their implementations are working correctly. I'd propose to add a test suite and...
Once/if https://github.com/libp2p/rust-libp2p/pull/2142 lands, we can use the protobuf encoding of `KeyPair` directly to store the identity file. Saves a couple of lines of code to convert to/from ed25519 keys.
Resolves #7. There is some duplication between the visitors so there is potential for follow-up work. The feature works however and is tested with 2 additional tests I added. Let...
First, thanks for this awesome crate! It makes working with hex-encoded data really a breeze :) We've ran into a nasty problem though when working with owned data. Concretely, given...
There were a few conflicts when merging in the changes. I ran [a diff against upstream](https://github.com/facebook/create-react-app/compare/main...thomaseizinger:pull-upstream) and the result looks sensible. Some local testing also confirms it works. Hopefully you'll...
Previously, we were using a timeout on the identify protocol to detect disconnected peers. Detecting closed browser tabs within the transport stack now works correctly so we no longer need...