universal-connectivity icon indicating copy to clipboard operation
universal-connectivity copied to clipboard
verified publisher icon libp2p

fix(rust): don't use failed identify messages to detect disconnection

Open thomaseizinger opened this issue 2 years ago • 3 comments

Previously, we were using a timeout on the identify protocol to detect disconnected peers. Detecting closed browser tabs within the transport stack now works correctly so we no longer need this hack.

I tested this locally using the latest deployed version on vercel.app.

thomaseizinger avatar Sep 24 '23 08:09 thomaseizinger

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universal-connectivity ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 2:06am

vercel[bot] avatar Sep 24 '23 08:09 vercel[bot]

Setting to draft until we have CI.

thomaseizinger avatar Sep 24 '23 08:09 thomaseizinger

While working on this, I noticed a strange behaviour @libp2p/js-libp2p-dev. The js-peer within this repository doesn't support the ping protocol. That is fine. What is weird is that I am running into negotiation timeouts when trying to use it. In other words, multistream-select doesn't seem to correctly respond with na. Instead, it seems to just not return anything.

thomaseizinger avatar Oct 04 '23 02:10 thomaseizinger