Thomas Eizinger
Thomas Eizinger
> > This is the main blocking comment of the PR, let me know if it is unclear for you how to proceed here :) > > No. Seems that...
> The exact encoding for `secp256k1` is to be decided, see [#190](https://github.com/libp2p/specs/issues/190). The encoding is decided (apparently it is the compressed form as described in the issue). #190 seems to...
> Checks failed for unmet minimum rustc version. That unfortunately makes this a breaking change, meaning it will have to wait a bit to merge. We are thinking of bumping...
> > > The exact encoding for `secp256k1` is to be decided, see [#190](https://github.com/libp2p/specs/issues/190). > > > > The encoding is decided (apparently it is the compressed form as described...
> > The idea of this work is to eventually replace `{In,Out}boundUpgrade` with a trait no longer does any (async) upgrading. Instead, we only want it to express, which protocols...
> I have issues with the new rustfmt version. Me too and I am somewhat surprised that the Rust team would ship that! > While I have no issues with...
> > > I have issues with the new rustfmt version. > > > > Me too and I am somewhat surprised that the Rust team would ship that! >...
With the :+1: from @mxinden and @elenaf9, I am removing the `decision-pending` label and putting this up for grabs.
Linking the original discussion here: https://github.com/libp2p/rust-libp2p/issues/1709 The motivation for adding this was to properly deal with upgrade errors. Hence, I'd suggest that we proceed here once https://github.com/libp2p/rust-libp2p/issues/2863 is implemented. Depending...
One thing that just came to my mind that is easier with the current design: Being able to pass state to as part of creating a new stream allows `ConnectionHandler`s...