Thomas Eizinger
Thomas Eizinger
> What's the benefit of a priority queue in this case? Great question! I think the benefit is that we end up sending the most important messages first, meaning if...
Thanks for the comments @divagant-martian @mxinden! I now see that the priority-channel was a detour 😅 The solution sketched above looks good, thank you @mxinden !
> I just wanted to throw into the mix the possibility that it could be our node that is slow. I think so far the assumption has been slow peers....
> Can you also please use `authenticate2` within the `SwarmBuilder` in the `libp2p` crate? In addition to the above comments, this is also still an open item. So far, we...
Sorry for the delay, I should have some time mid-January to review this.
> Thanks, I was already working on this. Awesome! Let me know when you want another review! :)
> @thomaseizinger pointed out that it might be simpler to use HKDF that will act as the seed for randomness (at what point? during certificate creation https://docs.rs/rcgen/0.10.0/rcgen/struct.CertificateParams.html#structfield.serial_number?). I think we...
If patching `rcgen` is too hard, we might also just inline the certificate generation. `ring` does all the heavy lifting of the crypto anyway and we don't need much configuration...
As mentioned in https://github.com/melekes/rust-libp2p/pull/12, this is blocked on https://github.com/briansmith/ring/commit/fe9e4d08c1727bea42d31e0d31ee58c4e8e4dc4e getting released and `webrtc` updating to that new `ring` release.
I think this would also be easier to resolve with #3659 because str0m depends on openssl and to parse the cerificate, meaning we don't necessarily need to use `ring` to...