Thomas Eizinger
Thomas Eizinger
I merged latest master because there was some diff of other PRs.
> `rsa::Keypair` may be parsed from DER encoding, which cannot be transformed to pkcs#8 encoding, making it impossible to be deserialized from protobuf encoding. What to do? This is a...
One final feature request: Can you generate a set of test vectors for each key type? In other words, generate a random key for each type and encode it to...
> > One final feature request: Can you generate a set of test vectors for each key type? In other words, generate a random key for each type and encode...
> > From the above, I would suggest we do (1) and require applications / other libraries that need to import from different crates to convert to our supported format....
> > > I found that crate `ecdsa` supports keys generated with secp256k1 curve, so I'm not sure why secp256k1 gets it's own implementation. > > > > I think...
@drHuangMHT I've updated the PR description as well. As this PR is becoming fairly large, I was wondering whether you'd be up for splitting it into multiple. For example, some...
> I can split the commits manually but that does need some time as a penalty for me being careless. So what about closing this PR later @thomaseizinger ? We...
> > @drHuangMHT I've updated the PR description as well. As this PR is becoming fairly large, I was wondering whether you'd be up for splitting it into multiple. For...
> > Sure, depending a crate to get some of the work done is completely fine, we don't need to write this from scratch. > > Crate `ecdsa` provides ability...