Thomas Eizinger
Thomas Eizinger
> > Surely that should not be hit when I am calling the function on a SendStream? > > Per the doc comments, `UnknownStream` can arise if the stream becomes...
> > But didn't we just conclude that such an error should only be returned from awaiting stopped? > > To be clear, it's usually a "you're calling methods in...
Okay, I might have a stab at this next week :)
> I'm using NixOS 23.05 I ran into the same thing. Here is how I applied the above: ```nix # File: configuration.nix systemd.packages = [ pkgs.yubikey-touch-detector ]; systemd.user.services.yubikey-touch-detector = {...
> If in the future somebody add a test with bad features flags, it will quickly see if it's not running How? I can write a test that is feature-gated...
I'll set this to draft because it is a breaking change!
> Another resource to check out if you haven't already is [how the JavaScript implementation of browser-to-browser works](https://docs.libp2p.io/guides/getting-started/webrtc/#step-8-pubsub-peer-discovery) (no need to re-invent the wheel, it should similar steps but just...
> @thomaseizinger, hey, did I miss something that still needs to be done? Sorry for the delay. I am on low availability until mid-Jan. Will give this a review after!...
> @thomaseizinger sorry, I thought criterion was not needed since you mentioned I should just comment out the benchmark, making the criterion benchmark is kind of hard since it requires...
Ideally we benchmark the following: 1. One protocols handler listening on many protocols (i.e. returning one large iterator). 2. Many handlers composed using `ConnectionHandlerSelect`, all returning a small number of...