rust-libp2p icon indicating copy to clipboard operation
rust-libp2p copied to clipboard
verified publisher icon libp2p

feat(identify): add connection_id in event

Open stormshield-frb opened this issue 2 years ago • 2 comments

Description

Fixes: #4980.

Notes & open questions

Change checklist

  • [x] I have performed a self-review of my own code
  • [x] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] A changelog entry has been made in the appropriate crates

stormshield-frb avatar Dec 05 '23 11:12 stormshield-frb

I'll set this to draft because it is a breaking change!

thomaseizinger avatar Jan 15 '24 02:01 thomaseizinger

This pull request has merge conflicts. Could you please resolve them @stormshield-frb? 🙏

mergify[bot] avatar Jan 29 '24 08:01 mergify[bot]

@stormshield-frb could you update this PR?

dariusc93 avatar Jun 13 '24 12:06 dariusc93

I've updated the PR and fixed some of the checks but I cannot manage to find why the semver check is failing sorry :/

stormshield-frb avatar Jun 14 '24 09:06 stormshield-frb

That shouldnt be a blocker to the pr since it is happening in others too

dariusc93 avatar Jun 14 '24 21:06 dariusc93