Thomas Eizinger

Results 1888 comments of Thomas Eizinger

FYI the new kid on the block of benchmarking doesn't need re-exports: https://nikolaivazquez.com/blog/divan/

I am currently travelling but will look at this in 2ish weeks time.

Good idea. That is orthogonal though, correct? We can ship an initial peer store without introducing such a variant (which is a breaking change). A `ToSwarm::NewPeerAddress` event should likely also...

> Okay, do we need changelogs for this? Should I also squish the commits? Yes, please write a changelog entry. Also `libp2p-swarm` needs to be bumped to `0.44.3`. No need...

The question is, is it worth doing the abstraction of a trait and deal with all the issues of e.g. futures that need to run on a specific executor (thinking...

@jakubDoka Can you attend the CI failures? Thanks!

> Also, I think storing in memory is fine for now, which is what I usually do although storing it elsewhere (eg database, on-disk, etc) is a nice-to-have solution down...

> @thomaseizinger How can I troubleshoot the workflows? I focused on fixing one and now I cant find the other one. Is there an easy way to run them locally?...

With https://github.com/libp2p/rust-libp2p/pull/4371 approved, this issue is now unblocked.