Thomas Eizinger
Thomas Eizinger
> Hi @thomaseizinger and @mxinden after some research I found that the tokio implementation take some time (about 10s ) to find the peers. > > I refactored the expiration...
> hi @thomaseizinger, I found out that **tokio::interval** works different than **AsyncIO::Timer::interval**, the first one fires the tick now and then during the period and the second one fires after...
> @thomaseizinger done with last comments. Thanks! Just one note for future PRs, we tend to not force-push on this repository because PRs will be squash-merged in the end so...
I've kicked CI again and will merge once it passes!
I've triggered the build and it is failing. Did this work for you locally?
We are likely going to move forward with https://github.com/libp2p/rust-libp2p/pull/2817 for this issue because it uses a different library to do the testing than what we use for the production code...
There is also a proposal in https://github.com/libp2p/rust-libp2p/issues/2173 to introduce features on the `libp2p-swarm` crate to fix this.
I think I would prefer a type-safe builder pattern that forces you to choose between calling `with_futures_executor()`, `with_tokio_executor()` etc. (Those functions could/should be feature-flagged ). The documentation of those functions...
I am closing this in favor of tracking it in https://github.com/libp2p/rust-libp2p/issues/3068.
That is a lot of breaking changes that I am not recognising 😅 Also, I think @mxinden is planning on releasing the next version as 0.45 (see #2662). Where is...