Thomas Eizinger

Results 1888 comments of Thomas Eizinger

> I suspect the `0.44.1` was derived from the fact that the [most recent package published](https://crates.io/crates/libp2p/0.44.0) was `0.44.0` I tried changing the version to `0.44.1` in root manifest and also...

Random guess: Could these issues arise from our workspace and re-exporting crates?

There is a lot of reformatting going on. Can we undo that so the actual diff is easier to see? Plus, as per your [comment](https://github.com/libp2p/rust-libp2p/issues/2635#issuecomment-1235715811), you are now experimenting with...

The comments are resolved but no new code has been pushed. Did you forget that maybe? :)

> > Very exciting! Thank you for working on this! > > Why does the workflow say that we skipped 18 checks? [libp2p/rust-libp2p/actions/runs/3074952477/jobs/4968044609#step:7:9](https://github.com/libp2p/rust-libp2p/actions/runs/3074952477/jobs/4968044609#step:7:9) > > After digging through and switching...

> Thanks for that recommendation @thomaseizinger , so it turns out we have [some issues](https://github.com/maschad/rust-libp2p/actions/runs/3162236722/jobs/5148652564#step:7:14) to fix. This was on `dcutr`, looks like we removed a `pub enum variant` potentially...

We currently have a failing semver check for 3 crates: https://github.com/libp2p/rust-libp2p/actions/runs/3254423615/jobs/5342659716 This is despite none of this code being touched since the last release. For `libp2p-core`, can this be related...