Thomas Eizinger

Results 1888 comments of Thomas Eizinger

Perhaps we should report the limit with each new connection?

This blogpost might also go onto a further reading list: https://sans-io.readthedocs.io/how-to-sans-io.html

> > This blogpost might also go onto a further reading list: [sans-io.readthedocs.io/how-to-sans-io.html](https://sans-io.readthedocs.io/how-to-sans-io.html) > > I am a great fan of this coding style. It makes testing so easy. >...

The actual issue is already being addressed: https://github.com/prometheus/client_rust/pull/78

Friendly note @pinkforest : We squash merge here and favor merges over force-pushes. Thank you :)

> @pinkforest why do we need both `cargo audit` and `cargo deny`? `cargo deny` doesn't open issues I think although we could potentially script that with the pre-installed `gh` CLI.

> I just switched the PR to be different flow with deny from periodic one that uses audit > > The periodic will catch any advisories and beep about them...

@mxinden @pinkforest I tried to summarize what this PR does in a new title. Improvements welcome!

@mxinden Feel free to merge if you also agree with the changes.

> > This does not compile because the blanket impl for `ProtocolName` over anything that implements `AsRef` is conflicting with the implementation on `Either`. > > I don't have a...