Tommy Hofmann
Tommy Hofmann
Some people (including me) stumbled over this today, even after closing and reopening the window.
Are you happy with your comments @fieker?
I will add my example as test and then merge it if you are happy
Seems to be about the new "book tests" added in Oscar. There seems to be a lot of noise and one "real" error at https://github.com/thofma/Hecke.jl/actions/runs/8673739125/job/23826928025?pr=1348#step:7:8421. @benlorenz is this expected to...
Yes and yes. I only used it for toying around so far, but your suggestions sound good.
The caller should call `simplify!`. Not sure we want to do it in this function.
We are checking `is_coprime` anyway, so we should just adjust it.
Since this is quite disruptive with little (no?) gain, I would suggest to put this on the back burner.
It is roughly 1 second for me. Sure, 0.x (0.9? 0.6?) seconds would be great, but I believe the ratio of gain and work is quite low compared to some...
I think the point is that it is not black and white what type piracy is. Is ``` *(x::Union{Integer, ZZRingElem}, ::ZZRing) ``` in Hecke type piracy? It might be the...