Tommy Hofmann

Results 702 comments of Tommy Hofmann

I have no strong opinion about the noncommutative setting. Just from looking at the name I cannot guess what `divexact_left`, `divexact_right`, `/` or `\` would do. The same confusion arises...

I had a quick chat with @fieker and the `/(x, y) = divexact(x, y)` seems like a good idea. To help the user, the error message for `/` (that is,...

If the `WeilDivisor` would be implemented like the `IdealSheaf`, there would be no need for the copy method. By this I mean that as mathematical objects they are immutable and...

You "stole" `special_linear_group` and `general_linear_group` by overloading it. Choose a different name for now.

@fingolfin @fieker There is a PR over at julia, and someone (don't want to ping them) used Hecke as a benchmark: https://github.com/JuliaLang/julia/pull/44527#issuecomment-1283106385. The improved timings are impressive. P.S.: Caching the...

Not resolved. We just fixed the cases that popped up.

If there is no difference between using code from experimental to normal code, there is no point of having experimental. Either the code in experimental is different for the user...