Thomas
Thomas
As far as I understood, they are non nullable. That's the reason, why I'd prefer to not introduce the pseudo nullable arguments. On the other hand, it's the least BC-risking...
I'd prefer not changing too much. The changes in this pr are no BC at all, but IMO at least `$name` shouldn't be nullable. The next best approach seems to...
Although I do understand your points and wishes for clean code, I don't have the time to take care of it now. But I'm happy if anyone else could take...
> > IIRC this depends on the version of SwiftMailer installed, or I am wrong? > > If this is true, we are not compatible with the latest version. Unfortunately,...
Any update on this? We ran into the same or at least a similar issue today. Creating a patch between the values `string(1) "0"` and `string(1) "1"` hangs infinitely.
I agree. One day, it will be required to drop older php versions and hopefully at least one of us remembers this issue and the discussions we already had 😛...
Ping, everything should have been fixed or at least be commented. How about merging and releasing this thing? Thanks for your effort, @Tybaze!
Any update @robertmarney? We are facing the same issue since we've upgraded from Laravel 6 to 9 a couple of days ago.
Hi @mtamazlicaru, please check again the issue described in the pull-request: https://github.com/Nimut/phpunit-merger/pull/19#issuecomment-922988634 Maybe yours is the same reason and the pr will fix it as well?
Hi @mtamazlicaru, could you already check the fix and did it solve your issue as well? I've found a couple of more issues and would be happy to contribute all...