Qiang Kou (KK)

Results 6 comments of Qiang Kou (KK)

I have a minor concern about the comparison. In xgboost code, the conversion to `DMatrix` is not included in the timing part: https://github.com/szilard/GBM-perf/blob/master/wip-testing/h2o4gpu/xgboost.py#L35 However, h2o4gpu timing results included this. It...

Hi, @alzmcr This is a somewhat "classical" problem. Can you try to replace `isnan` with `std::isnan` in https://github.com/dmlc/cxxnet/blob/master/src/updater/sgd_updater-inl.hpp#L19 ? Let me know if it works.

This should have been fixed in https://github.com/dmlc/mshadow/pull/211 Please close it.

@arogozhnikov You need to add `-std=c++11` into `CFLAGS`. You can use the Makefile in `guide` folder as an example: https://github.com/dmlc/mshadow/blob/master/guide/Makefile#L7

Sorry that I have very little knowledge on gradle.