contracts

contracts copied to clipboard

Request for Hardhat Deployment Example for TokenStake Contract

1

## Description I am planning to deploy the `TokenStake` contract using Hardhat and would appreciate guidance on the recommended deployment procedure. I am particularly interested in understanding the best practices...

terry1ee

Issue: This view function is semantically wrong, the auction is expired only if `endTimestamp` is less than `block.timestamp`. Solution: Fixes operator sign to `=`

karacurt

The actual function is considering active auctions as expired (if endTimestamp is in the future) ```solidity function isAuctionExpired(uint256 _auctionId) external view onlyExistingAuction(_auctionId) returns (bool) { return _englishAuctionsStorage().auctions[_auctionId].endTimestamp >= block.timestamp; }...

karacurt

fix some typos

xiaoxianBoy

check EIP1271 signatures

1

kumaryash90

In the `collectAuctionPayout` function, it becomes apparent that the variable `paidOutBidAmount` is set to `true` before the necessary `require` checks are performed. This has the potential to cause an issue...

Leechael

Forge build runs out of memory for the project

1

Hello! I'm just starting with thirdweb contracts, but when I try to run forge build, solc crashes saying SIGKILL 9, which I take means it runs out of memory. I...

jindra12

Remove unused imports in prebuilts

1

Multiple contracts in the `prebuilts` folder are importing unused directives which may be confusing and make the code less clean.

gabrielstoica

**Add Tests for Signature Validation and Gas Efficiency** I added the testFailMintWithInvalidSignature to check if minting with an invalid signature fails as expected. Introduced testGasMinting to log gas usage during...

ianpurifying

An audit has been added to the documentation

oksanaphmn