contracts icon indicating copy to clipboard operation
contracts copied to clipboard

fix: auction payout can be locked before execute

Open Leechael opened this issue 1 year ago • 0 comments

In the collectAuctionPayout function, it becomes apparent that the variable paidOutBidAmount is set to true before the necessary require checks are performed. This has the potential to cause an issue where the auction creator does not receive their tokens, even if the auction is successful and has expired.

https://github.com/thirdweb-dev/contracts/blob/a9e647790a42e224d09e8b010b8bd892a0e4678c/contracts/prebuilts/marketplace/english-auctions/EnglishAuctionsLogic.sol#L147-L166

This PR aims to fix the potential issue.

Leechael avatar Apr 03 '24 04:04 Leechael