contracts issues

ManagedAccount benchmarks

3

``` Running 18 tests for src/test/benchmark/ManagedAccountBenchmark.t.sol:ManagedAccountTest [PASS] test_deploy_managedAccount() (gas: 8565484) [PASS] test_revert_executeTransaction_nonSigner_viaDirectCall() (gas: 313743) [PASS] test_revert_executeTransaction_nonSigner_viaEntrypoint() (gas: 48762) [PASS] test_revert_onRegister_nonFactoryChildContract() (gas: 12909) [PASS] test_scenario_changeExtensionForFunction() (gas: 52098) [PASS] test_state_accountReceivesNativeTokens() (gas: 20756)...

alfheimrShiven

[EIP 4337] Withdrawing tokens from a contract to a smart account fails

3

Withdrawing native tokens from to a smart account throws unpredictable gas error. This is preventing our users to use 1Inch API to swap ERC tokens into Native tokens. Digging more...

alko89

Can't verify contract deployed on Shibarium

One of the user suggested to add indexer to the contract. > Also please add the indexer function too, there is no tokenOfOwnerByIndex() or tokensOfOwner() Example contract: https://www.shibariumscan.io/token/0x9989a29F7a60603e6704dE5daD5e9cf778f8f805?tab=read_contract According to...

warengonzaga

Update ERC1155Base.sol

The sole aim of this PR is to enhance these 'for' loops in order to reduce gas costs.. [This](https://gist.github.com/grGred/9bab8b9bad0cd42fc23d4e31e7347144#for-loops-improvement) can be used as a reference Thanks! @WhiteOakKong @nkrishang

0xScratch

Dynamic account benchmark tests

2

Here's the `DynamicAccountBenchmark.t.sol` gas consumption report: ```zsh Running 15 tests for src/test/benchmark/DynamicAccountBenchmark.t.sol:DynamicAccountBenchmarkTest [PASS] test_deploy_dynamicAccount() (gas: 7301210) [PASS] test_scenario_changeExtensionForFunction() (gas: 1940259) [PASS] test_state_accountReceivesNativeTokens() (gas: 1552985) [PASS] test_state_addAndWithdrawDeposit() (gas: 1622561) [PASS] test_state_createAccount_viaEntrypoint()...

alfheimrShiven

BTT test token stake

WhiteOakKong

[ERC721Base] missing virtual on internal function _msgSender

2

Hello, I believe we should be able to override this function but it is not marked as `virtual`. https://github.com/thirdweb-dev/contracts/blob/114df579c7bc4087384d06b2d562fe0cb255c06a/contracts/base/ERC721Base.sol#L207

ArthurD1