[ERC721Base] missing virtual on internal function _msgSender

Open ArthurD1 opened this issue 1 year ago • 2 comments

Hello,

I believe we should be able to override this function but it is not marked as virtual.

https://github.com/thirdweb-dev/contracts/blob/114df579c7bc4087384d06b2d562fe0cb255c06a/contracts/base/ERC721Base.sol#L207

May 10 '24 09:05 ArthurD1

It's a valid point that the _msgSender() function should be marked as virtual to allow for easier customization and overrides in derived contracts.I suggest adding the virtual modifier to the _msgSender() function to enable this feature.

Jun 03 '24 21:06 Iamalok007

If you could assign this issue to me, I'd be glad to implement the necessary changes.

Jun 03 '24 21:06 Iamalok007