Kevin Kipp

Results 36 comments of Kevin Kipp

@Goramilla I've created and published a dependency free package based on this plugin. Give it a try and let me know what you think! https://github.com/third774/image-focus

I think success styles being enabled by default makes sense, and thus the option should probably be called `disableSuccessState`. Thoughts?

Thanks for mentioning this! Can you expand on what you mean by excessive? Configuring the module in one place with a class that should be used everywhere seems reasonable, but...

This functionality seems like it would be covered under [Custom Error Messages](https://github.com/third774/ng-bootstrap-form-validation#custom-error-messages). Can you explain further if it isn't?

Rather than `ngFormValidator`, should this be something like `ngBootstrapFormValidator` to be more namespaced to the package?

Thinking about this a bit more and feeling like the `onSubmit` handler shouldn't be callable by library consumers. Perhaps the code within that handler should be pulled out into a...

First of all, thank you for making this package. It's _fantastic_! I'm also running into an issue where I would like to have more control over the positioning of the...

@benoitgrelard `#2` addresses our wants/needs!

Gotcha! Sounds like we need to add a `.dispose()` method?

FWIW at this point I'd just recommend using `object-position`. https://kevinkipp.com/blog/til-object-position/