Thibeau Fuhrer

Results 78 comments of Thibeau Fuhrer

Hi @alex40724 As far as I understand, there are already different commands for this in `PageCommandActionHandler`. So it would already be possible to distinguish temporary from actual deletes. The problem...

I'm not quite sure what handleDeleteContent() does, but if I understand correctly it's not responsible for removing the element on the page right? Because then the move-flag approach would make...

@alex40724 I remove the `handleDeleteContent()` in `ilPageObject::deleteContent` too because this method was only called for move-events.

Hi @alex40724, I wanted to ask again if this solutions is acceptable now?

As mentioned by @klees I removed the debug conditions from the thrown exceptions, since there's a serious problem if one of them is reached. Though when doing this I noticed...

Hi @klees Thx for the hint, according to the guideline which states: > If a configuration contains decisions or fields that can only be known reliably by the server administrator,...

Hi all I've finally moved the configuration of the authentication-time to the ILIAS setup as pointed out by @klees in a previous comment. I also added some minimal test-cases that...

Hi @mjansenDatabay and thanks for your approval =). Let me elaborate on the `ilAccountRegistrationGUI` a bit: For obvious reasons it shouldn't be possible to create two accounts with the same...

Hi all I've applied the mechanism for the `ilPasswordAssistanceGUI` now as well. I thought @mjansenDatabay was responsible for this class, thats why I re-requested his review. You can ignore that...