Thibeau Fuhrer

Results 78 comments of Thibeau Fuhrer

Hi @klees, Thx for your feedback! - Icons: I have added them to the usage rule 4 as well. - A11y: I have added a rule among these lines, but...

Hi @Amstutz and @klees, this should ready for technical review now. Once I have your go-ahead, I will amend the failing unit tests and make our pipelines happy.

This PR adds the `@jest/globals` as `npm` package. Usage: - All JavaScript unit tests, primarily in `components/ILIAS/UI/tests/*`. Wrapped By: - Not applicable. Reasoning: - This package handles: - It provides...

This PR adds the `@babel/preset-env` as `npm` package. Usage: - JavaScript unit tests, primarily in `components/ILIAS/UI/tests/*`. - JavaScript module bundling, primarily in `components/ILIAS/UI/tests/*`. Wrapped By: - Not applicable. Reasoning: -...

Just stumbled over this. I picked this manually now because of the failed pipeline, but thx for the PR and fix!

Hi all, I have committed the update of braces in dda8c3952e49df77bf4d83d8cf2897ee9994b976 and performed an `npm clean-install --ignore-scripts --omit=optional` to properly install the dependencies. It looks like this wasn't done in...

- befd512f27c61efeab1947c89d08cf5a5bd263ed - a1480d54c7482a0bba8fa9d51d986d78e35c08ca

Hi @lscharmer Thx for looking into this topic again. Before we invest time into reviewing this, could you explain how this proposal is different from the solution using an overlay,...